palantir / palantir/palantir-java-format
Join string concatenations if they end up on the same line
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 907
- Forks
- 101
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 19
Description
What happened?
throw new SafeIllegalArgumentException("Invalid recipient field - contains multiple "
+ "foreign key properties.", UnsafeArg.of("field", maybeField));
gets turned into
throw new SafeIllegalArgumentException(
"Invalid recipient field - contains multiple " + "foreign key properties.", UnsafeArg.of("field", maybeField));
but the + is left behind.
What did you want to happen?
There should be a single string literal and no +.
Implementation wise, my intuition is that we should rewrap string concatenations that end up being moved in normal formatting, which will achieve this.
Currently, StringWrapper.wrap will bail out if there are no overly long lines.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in StringWrapper.wrap and reproduce the shown formatting transformation with the Java examples from the issue. Trace why wrapping is skipped when no line remains overlong, then verify that a moved concatenation becomes one string literal with no + and that normal formatting remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100