palantir / palantir/palantir-java-format

Assignment inlining should still break if same number of lines

Open
#61 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
907
Forks
101
Avg merge
1d 3h
Merged PRs (30d)
19

Description

What happened?

We try to inline the prefix of initializers for assignments / declarations.

This can sometimes produce uglier code that doesn't even save space (takes up the same amount of lines).

For example:

Optional<DecoratedResource> maybeParent = parentId.filter(
                rid -> permissionsManager.canCreateSomeResource(authHeader, rid))
        .flatMap(...);

whereas what you really want is

Optional<DecoratedResource> maybeParent = parentId
        .filter(rid -> permissionsManager.canCreateSomeResource(authHeader, rid))
        .flatMap(...);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the formatter logic for inlining assignment or declaration initializers, then reproduce the two Java examples. Done means an initializer is not inlined when the resulting layout uses the same number of lines and the example keeps the preferred line break.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.