palantir / palantir/palantir-java-format
Assignment inlining should still break if same number of lines
Open
Nobody has claimed this yet.
bug
- Dominant language
- Java
- Stars
- 907
- Forks
- 101
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 19
Description
What happened?
We try to inline the prefix of initializers for assignments / declarations.
This can sometimes produce uglier code that doesn't even save space (takes up the same amount of lines).
For example:
Optional<DecoratedResource> maybeParent = parentId.filter(
rid -> permissionsManager.canCreateSomeResource(authHeader, rid))
.flatMap(...);
whereas what you really want is
Optional<DecoratedResource> maybeParent = parentId
.filter(rid -> permissionsManager.canCreateSomeResource(authHeader, rid))
.flatMap(...);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating the formatter logic for inlining assignment or declaration initializers, then reproduce the two Java examples. Done means an initializer is not inlined when the resulting layout uses the same number of lines and the example keeps the preferred line break.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100