palantir / palantir/palantir-java-format

Reformatter doesn't respect line length constraint when there is inner class

Open
#330 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
907
Forks
101
Avg merge
1d 3h
Merged PRs (30d)
19

Description

For a variable definition where the variable uses inner class

private static final ClusterLauncher.ClusterLaunchResponse CLUSTER_LAUNCH_RESPONSE =
        ClusterLauncher.ClusterLaunchResponse.of(URI, ENVIRONMENT_PARAMS);

the formatter reformatted it to

private static final ClusterLauncher.ClusterLaunchResponse CLUSTER_LAUNCH_RESPONSE = ClusterLauncher.ClusterLaunchResponse
        .of(URI, ENVIRONMENT_PARAMS);

where the first line is longer than the line length constraint

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the formatter behavior with the inner-class variable definition shown in the issue, then trace the formatting path for variable declarations and qualified inner-class types. Done means the reformatted output respects the configured line-length constraint for this example, with coverage for the regression if the repository's existing test structure identifies a suitable location.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.