palantir / palantir/palantir-java-format
Support for module import
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 907
- Forks
- 101
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 19
Description
import module java.base; is now out of preview and should be supported by this formatter. Instead it fails with
LINE_UNDEFINED removeUnusedImports(java.lang.IllegalArgumentException) object of type com.sun.tools.javac.tree.JCTree$JCModuleImport is not an instance of com.sun.tools.javac.tree.JCTree$JCImport (...)
and
LINE_UNDEFINED palantir-java-format(com.palantir.javaformat.java.FormatterException) error: Expected ; after import (...)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the formatter failures with import module java.base;, then trace how module imports are parsed and handled by unused-import removal. Done means the formatter accepts and formats this import without either reported exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100