palantir / palantir/palantir-java-format

Formatting improvements are needed for record classes.

Open
#1,230 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
907
Forks
101
Avg merge
1d 3h
Merged PRs (30d)
19

Description

It seems that the indentation is applied incorrectly for record classes.

What happened?
public record Hello(
        @Deprecated(
                        since =
                                "record formatting test... record formatting test... record formatting test... record formatting test... ")
                String v1,
        @Deprecated(
                        since =
                                "record formatting test... record formatting test... record formatting test... record formatting test... ")
                String v2,
        @Deprecated(
                        since =
                                "record formatting test... record formatting test... record formatting test... record formatting test... ")
                String v3,
        @Deprecated(since = "record formatting test... record formatting test...") String v4,
        @Deprecated(since = "record formatting test... record formatting test...") String v5) {

    public record World(
            @Deprecated(
                            since =
                                    "record formatting test... record formatting test... record formatting test... record formatting test... ")
                    String v1,
            @Deprecated(
                            since =
                                    "record formatting test... record formatting test... record formatting test... record formatting test... ")
                    String v2,
            @Deprecated(
                            since =
                                    "record formatting test... record formatting test... record formatting test... record formatting test... ")
                    String v3,
            @Deprecated(since = "record formatting test... record formatting test...") String v4,
            @Deprecated(since = "record formatting test... record formatting test...") String v5) {}
}
What did you want to happen?
public record Hello (
    @Deprecated(
            since =
                    "record formatting test... record formatting test... record formatting test... record formatting test... ")
    String v1,

    @Deprecated(
            since =
                    "record formatting test... record formatting test... record formatting test... record formatting test... ")
    String v2,

    @Deprecated(
            since =
                    "record formatting test... record formatting test... record formatting test... record formatting test... ")
    String v3,

    @Deprecated(since = "record formatting test... record formatting test...")
    String v4,

    @Deprecated(since = "record formatting test... record formatting test...")
    String v5) {

    public record World (
        @Deprecated(
                since =
                        "record formatting test... record formatting test... record formatting test... record formatting test... ")
        String v1,

        @Deprecated(
                since =
                        "record formatting test... record formatting test... record formatting test... record formatting test... ")
        String v2,

        @Deprecated(
                since =
                        "record formatting test... record formatting test... record formatting test... record formatting test... ",
                forRemoval = true)
        String v3,

        @Deprecated(since = "record formatting test... record formatting test...", forRemoval = true)
        String v4,

        @Deprecated(since = "record formatting test... record formatting test...")
        String v5
    ) {}
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source files or tests are named. Start by reproducing the record-class formatting example from the issue, including nested records and annotations; done means the formatter output matches the requested indentation, spacing, blank lines, and annotation wrapping.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.