palantir / palantir/go-java-launcher

Incorrect absolutization of classpath argument

Open
#93 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
76
Forks
29
Avg merge
11h 34m
Merged PRs (30d)
25

Description

The absolutizeClasspathEntries method here...

https://github.com/palantir/go-java-launcher/blob/312f8b2004e221bba0707dda4858b873b102ed5e/launchlib/launcher.go#L189

...doesn't seem to take into account if the classpath is already in absolute format.

I think the absolutizeClasspathEntries should check if the entry starts with a / and if so, don't prepend the working directory.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in launchlib/launcher.go at the absolutizeClasspathEntries method around line 189. Check how it handles classpath entries that are already absolute, then verify that absolute entries remain unchanged while relative entries still use the working directory; the issue does not name a test file.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.