palantir / palantir/go-java-launcher

Overriding javaHome in launcher-custom.yml doesn't work

Open
#79 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
76
Forks
29
Avg merge
11h 34m
Merged PRs (30d)
25

Description

What happened?

As part of the Java8 -> Java11 migration, we've advised people that if anything goes wrong in prod you can just add javaHome: $JAVA_8_HOME to your launcher-custom.yml and restart to get back to the old behaviour.

What did you want to happen?

Unfortunately, go-java-launcher seems to ignore this field (and doesn't actually fail).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Java 8 fallback scenario with javaHome: $JAVA_8_HOME in launcher-custom.yml, then trace how that configuration is parsed and applied by the launcher. Done means the override is honored when restarting, or the configuration fails clearly instead of being silently ignored.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.