palantir / palantir/go-java-launcher
Allow for tildes on exec path if they aren't the start of the path
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 76
- Forks
- 29
- Avg merge
- 11h 34m
- Merged PRs (30d)
- 25
Description
We use tildes in install paths (/foo/bar/baz/group~value~id). This doesn't jive well with the current regex: https://github.com/palantir/go-java-launcher/blob/develop/launchlib/launcher.go#L110 when the provided JAVA_HOME is a subdirectory of that install path.
Request is to allow tildes if they aren't at the beginning of the path (AKA won't resolve to the home directory).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in launchlib/launcher.go around line 110, where the current path-matching regex handles tildes. Check how a JAVA_HOME nested under an install path containing internal tildes is interpreted. Done means paths with tildes that are not at the beginning are accepted without changing leading-tilde home-directory handling; the payload names no test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100