palantir / palantir/go-java-launcher
System environment variables not appended to with user defined value
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 76
- Forks
- 29
- Avg merge
- 11h 34m
- Merged PRs (30d)
- 25
Description
I have a stack where LD_LIBRARY_PATH is set in the user environment, and we want to append to it when launching our app. Our launcher-static.yml contains the following:
env:
LD_LIBRARY_PATH: "{{CWD}}/service/staf/linux-x86_64/lib"
The system environment has this defined:
$ echo $LD_LIBRARY_PATH
/opt/palantir/postgresql95/usr/pgsql-9.5/lib:/opt/palantir/postgresql95/usr/lib64:/opt/palantir/postgresql95/usr/lib64/atlas:/opt/palantir/postgresql95/lib64:
And on startup we get the following:
2017-01-12 14:48:59,004 INFO [main] EnterpriseManager - LD_LIBRARY_PATH = /opt/palantir/postgresql95/usr/pgsql-9.5/lib:/opt/palantir/postgresql95/usr/lib64:/opt/palantir/postgresql95/usr/lib64/atlas:/opt/palantir/postgresql95/lib64:
Ideally the launcher-static environment variable would actually get appended to they system environment variable.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting how environment variables from launcher-static.yml are loaded and passed to the launched Java process. Reproduce the LD_LIBRARY_PATH case from the issue, then verify that the configured value is appended to the existing system value without dropping either portion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100