palantir / palantir/go-java-launcher
Support for container launcher-static configuration
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 76
- Forks
- 29
- Avg merge
- 11h 34m
- Merged PRs (30d)
- 25
Description
In recent versions of Java, JVM memory configuration has become a bit more sophisticated with supporting launching processes in containers. Specifically, there is a desire to want to utilize some memory configuration flags that only work within containers (eg: MinRAMPercentage/MaxRAMPercentage), but this currently isn't possible with the launcher because it needs to support launching processes not in containers.
It's been proposed to bake some logic into go-java-launcher to detect the CONTAINER=true env var (see gradle-sls-docker's Dockerfile on internal github) and and then flip between a container launcher-static and a regular launcher-static.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue concerns go-java-launcher and refers to the gradle-sls-docker Dockerfile on an internal GitHub repository, but names no local file or test. Start by locating the launcher-static configuration and the entry point that selects it. Done means container launches use the container-specific memory flags when CONTAINER=true while non-container launches retain the regular configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, java
- Domain
- cli, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100