palantir / palantir/go-githubapp
PrepareRepoContext should take an interface
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 450
- Forks
- 70
- Avg merge
- 14h 23m
- Merged PRs (30d)
- 26
Description
go-github has a variety of repository-like objects, notably Repository and PushEventRepository. Since PrepareRepoContext only cares about a few fields accessed via getters, we should define an interface to accommodate the various repository objects.
We should use the same interface in PreparePRContext.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in githubapp/context.go at PrepareRepoContext and inspect the getters it uses, then compare PreparePRContext. Define the shared repository interface requested by the issue and update both helpers so they accept repository-like objects such as Repository and PushEventRepository; run the project tests to confirm the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100