palantir / palantir/conjure-python
Missing `Bearer` in header authorization?
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 27
- Forks
- 19
- Avg merge
- 12h 22m
- Merged PRs (30d)
- 15
Description
According to the wire spec, Bearer shall be part of the generated auth header, but it's not the case based on the current implementation:
https://github.com/palantir/conjure-python/blob/e83523687fe4b119a76240e57f80708fc521e7d5/conjure-python-core/src/main/java/com/palantir/conjure/python/poet/PythonEndpointDefinition.java#L147-L149
I drafted https://github.com/palantir/conjure-python/pull/981, but I understand the change could be breaking. Just would like to put it on the radar.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the wire specification's header authorization section and the referenced lines in conjure-python-core/src/main/java/com/palantir/conjure/python/poet/PythonEndpointDefinition.java. Compare the generated authorization header with the specification and the drafted pull request 981; done means the generated header includes Bearer consistently with the wire spec.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, python
- Domain
- api, authentication
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 30/100