palantir / palantir/conjure-python
Generated visitors are not generic on returned type
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 27
- Forks
- 19
- Avg merge
- 12h 22m
- Merged PRs (30d)
- 15
Description
Visitors are generated like this:
class Visitor:
@abstractmethod
def _variant_a(self, variant_a: "VariantA") -> Any:
pass
@abstractmethod
def _variant_b(self, variant_b: "VariantB") -> Any:
pass
It feels possible to define something like:
class Visitor(Generic[T]):
@abstractmethod
def _variant_a(self, variant_a: "VariantA") -> T:
pass
@abstractmethod
def _variant_b(self, variant_b: "VariantB") -> T:
pass
and also potentially make it backwards compatible.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by locating the generator entry point that emits the shown Python Visitor classes, then inspect how their return annotations are produced and how generated APIs are tested. Done means generated visitors support a generic return type while preserving backwards compatibility.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100