palantir / palantir/conjure-java

Wrap query params in their own object

Open
#698 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
39
Forks
49
Avg merge
8h 22m
Merged PRs (30d)
32

Description

Adding optional query params is back-compat, but does deprecate the old method. To avoid deprecation, it would be nice to invoke calls that use query params by wrapping the params in an object of their own. These non-strict builders would then compile in the presence of added fields.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Java generator code that produces client and server methods with query parameters, then inspect how generated method signatures and compatibility behavior are tested. The work is done when query parameters are represented by their own object and the intended non-strict builder behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.