palantir / palantir/conjure-java

Make 'RequireNotNullAuthAndBodyParams' enabled by default

Open
#51 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
39
Forks
49
Avg merge
8h 22m
Merged PRs (30d)
32

Description

This feature flag was introduced in https://github.com/palantir/conjure-java/pull/38 as a way of doing a gradual rollout. Once we've validated a few repos can use this successfully, this flag should be removed and the functionality enabled by default.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading pull request #38, which introduced the RequireNotNullAuthAndBodyParams feature flag, and trace where that flag is handled in the generator. Confirm how the generated Java clients and servers currently behave, then remove the gradual-rollout path and make the functionality the default, with tests covering the resulting behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.