palantir / palantir/conjure-java
Track removing JsonIgnoreProperties from beans
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 39
- Forks
- 49
- Avg merge
- 8h 22m
- Merged PRs (30d)
- 32
Description
What happened?
Due to a regression introduced earlier on, we generate @JsonIgnoreProperties on all beans:
which overrides the distinct configuration we had intended for servers as opposed to clients:
What did you want to happen?
https://github.com/palantir/conjure-java/pull/121 should be merged once we are certain that this won't break existing clients.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with BeanBuilderGenerator.java around lines 99-100 and ObjectMappers.java around line 67 to understand the conflicting JsonIgnoreProperties behavior. Review pull request 121 and verify whether removing the generated annotation could break existing clients. Done means the change is tracked through a merge decision with client compatibility confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100