palantir / palantir/conjure-java
nonNullCollections flag isn't being respected for alias types
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 39
- Forks
- 49
- Avg merge
- 8h 22m
- Merged PRs (30d)
- 32
Description
What happened?
We have the following conjure type:
AndSearchFilter:
docs: |
A SearchFilter used to combine multiple SearchFilters.
A row satisfies this SearchFilter if and only if it satisfies all combined SearchFilters.
alias: set<SearchFilter>
And we have enabled the nonNullCollections flag to enforce that the set cannot contain null entries. However, this is not being enforced.
What did you want to happen?
Constructing the AndSearchFilter with a set containing null should fail.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the generator handles the nonNullCollections flag for alias types, using the AndSearchFilter alias set example to reproduce the problem. Confirm the existing generated construction and validation path, then verify that constructing the alias with a null entry fails.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100