palantir / palantir/conjure-java-runtime
Non-idempotent read timeouts are retried
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 95
- Forks
- 96
- Avg merge
- 3h 38m
- Merged PRs (30d)
- 33
Description
What happened?
A non-idempotent HTTP request was retried when the original request failed due to a read timeout.
The retried request succeeded. However the original request also eventually succeeded. This left the service in an incorrect state because an action that should have only been attempted once was performed twice.
What did you want to happen?
Requests should only be retried if either:
- The request is idempotent, according to the HTTP spec
- The request did not send any data to the server (ex. a connect timeout)
Differentiating between connect timeouts and read timeouts is currently an open issue in OkHttp:
https://github.com/square/okhttp/issues/3318
Until that issue is resolved, we should bias towards the more limiting, but safe behavior of not retrying non-idempotent requests.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named in the issue. Start by locating the retry handling for HTTP read timeouts and reviewing its existing tests; done means non-idempotent requests are not retried after a read timeout, while the intended retry behavior for idempotent requests remains intact.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend, networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100