palantir / palantir/conjure-java-runtime
Retrofit clients should treat HTTP 204 as empty
Open
Nobody has claimed this yet.
bug
- Dominant language
- Java
- Stars
- 95
- Forks
- 96
- Avg merge
- 3h 38m
- Merged PRs (30d)
- 33
Description
Our jax-rs clients already interpret a http 204 as Optional.empty, but the retrofit clients return it as null!
@Test
public void retrofit2_client_can_retrieve_an_optional_empty() throws Exception {
assertThat(client.optionalEmpty(AuthHeader.valueOf("authHeader")).execute().body())
.isEqualTo(Optional.empty());
}
org.junit.ComparisonFailure:
Expected :Optional.empty
Actual :null
<Click to see difference>
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the retrofit2_client_can_retrieve_an_optional_empty test and the Retrofit client implementation it exercises. Reproduce the failure, then trace how an HTTP 204 response is converted for Optional results; done means the test returns Optional.empty rather than null and passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100