palantir / palantir/conjure-java-runtime
Assert there's no BODY for http-code-200 responses for POST methods returning void
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 95
- Forks
- 96
- Avg merge
- 3h 38m
- Merged PRs (30d)
- 33
Description
If a proxy decides to redirect the request to say an authentication service, then the caller gets back a 200 with some html BODY (the login page), even though the POST request definitely did NOT succeed.
If we're handling a POST that returns void and we get back a response with a BODY, http-remoting should force the http-error-code to be something like a 500.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named in the issue. Start by locating the http-remoting handling for POST requests that return void, then reproduce a 200 response containing a body and verify that it is converted to an HTTP error such as 500.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100