palantir / palantir/conjure-java-runtime

Propagate tracing information when limiter times out

Open
#1,564 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
95
Forks
96
Avg merge
3h 38m
Merged PRs (30d)
33

Description

What happened?

I get the warning log for when a concurrency limiter has timed out, but it doesn't have a traceId.

https://github.com/palantir/conjure-java-runtime/blob/d2894c66f591c107ace75ee62357904293bb0d9c/okhttp-clients/src/main/java/com/palantir/conjure/java/okhttp/ConcurrencyLimiters.java#L276

What did you want to happen?

It would be useful to know which incoming request to my server timed out when trying to make an outbound request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in okhttp-clients/src/main/java/com/palantir/conjure/java/okhttp/ConcurrencyLimiters.java at the timeout warning around line 276. Trace how the incoming request's tracing information is available when the limiter times out, and inspect nearby logging and limiter code. Done means the timeout warning identifies the incoming request with its traceId.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.