palantir / palantir/conjure-java-runtime-api
SerializableError throws NPE if any of the SafeArgs are null
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 6
- Forks
- 33
- Avg merge
- 15h 50m
- Merged PRs (30d)
- 12
Description
This shouldn't thrown an NPE if the call to .getValue() returns null (which can happen if the caller doesn't do something like Strings.nullToEmpty() on all possible values).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in errors/src/main/java/com/palantir/remoting/api/errors/SerializableError.java at line 119 and inspect the SafeArgs value handling. Reproduce the case where getValue() returns null, then verify that SerializableError no longer throws an NPE for that input and run the relevant existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100