palantir / palantir/conjure-java-runtime-api

Upper camel case regexp in ErrorType is not valid

Open
#110 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
6
Forks
33
Avg merge
15h 50m
Merged PRs (30d)
12

Description

It does not accept single uppercase letter (https://github.com/palantir/http-remoting-api/blob/develop/errors/src/main/java/com/palantir/remoting/api/errors/ErrorType.java#L33), e.g. "Foo:B" will not be a valid error name.

Regexp like ([A-Z]([a-z0-9]+[A-Z])*[a-z0-9]*) could solve this issue.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at errors/src/main/java/com/palantir/remoting/api/errors/ErrorType.java#L33 and inspect the current ErrorType name validation regexp. Check the reported "Foo:B" case alongside existing valid names, then run the relevant Java tests or validation checks. Done means single-uppercase-letter segments are accepted without breaking existing error-name validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.