palantir / palantir/conjure-java-runtime-api
New ServiceExceptionAssert.hasArgSatisfying(...) assertion
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 6
- Forks
- 33
- Avg merge
- 15h 50m
- Merged PRs (30d)
- 12
Description
What happened?
I have an arg that's a long, dynamically computed string (a stacktrace). I'd like to confirm that it contains a certain substring, with a syntax like:
assertThatServiceExceptionThrownBy(() -> throwIt())
.hasType(MyErrors.MY_ERROR)
.hasArgSatisfying(arg -> {
assertThat(arg.getName()).isEqualTo("my-arg");
assertThat(arg.getValue()).asString().contains("my-substring");
});
or maybe like this:
assertThatServiceExceptionThrownBy(() -> throwIt())
.hasType(MyErrors.MY_ERROR)
.hasArgWithNameSatisfying("my-arg", value -> assertThat(value).asString().contains("my-substring"));
Workaround
Right now I'm doing something like this, but would love to improve it:
assertThatServiceExceptionThrownBy(() -> throwIt())
.hasType(MyErrors.MY_ERROR)
.satisfies(serviceException -> assertThat(serviceException.getArgs())
.satisfiesOnlyOnce(arg -> {
assertThat(arg.getName()).isEqualTo("my-arg");
assertThat(arg.getValue()).asString().contains("my-substring");
});
});
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating ServiceExceptionAssert and its existing argument assertion methods. Review how those assertions are tested, then add a callback-based argument assertion matching the requested usage and cover successful matching and failure cases in the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100