Portal 2 crash when alt-tabing
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 122
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
Portal 2 sometimes crashes when I have SAR loaded and try to alt-tab (I play in fullscreen mode). Cannot reliably reproduce, but already happened a few times; issue seems related to thread pool cleanup (edit: i'm dumb, this is portal's function, Engine::Frame_Hook is sar):
SAR 1.12.8-pre6 (Built 03:20:34 Nov 22 2022)
Segmentation fault caused by address 0x7b0ae911
(+0x0) [0x7b0ae911]
(+0x0) [0x7b0aed3d]
(+0x0) [0x7b0b27ca]
(+0x0) [0x79215084]
(+0x0) [0x791ff332]
(+0x0) [0x791ff381]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(DestroyThreadPool+0x5b07a5c0) [0x5b07a5c0]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(DestroyThreadPool+0x5b07ae9f) [0x5b07ae9f]
(+0x0) [0x791fcf34]
(+0x0) [0x791fea96]
(+0x0) [0x791fd7a5]
(+0x0) [0x79202a23]
(+0x0) [0x78b8b169]
(+0x0) [0x78c3688c]
(+0x0) [0x78c38fe3]
(+0x0) [0x78c47b1b]
(+0x0) [0x78c47c6a]
(+0x0) [0x78c47d04]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(F+0x78c9a15d) [0x78c9a15d]
D:\SteamLibrary\steamapps\common\Portal 2\sar.dll(Engine::Frame_Hook+0x20606a) [0x254c606a]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(F+0x78c98f40) [0x78c98f40]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(F+0x78c9905f) [0x78c9905f]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(F+0x78c99a9e) [0x78c99a9e]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(LauncherMain+0x5b1790c0) [0x5b1790c0]
(+0x0) [0x009311dc]
(+0x0) [0x0093177e]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(BaseThreadInitThunk+0x76a0fef9) [0x76a0fef9]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(RtlGetAppContainerNamedObjectPath+0x77147bbe) [0x77147bbe]
D:\SteamLibrary\steamapps\common\Portal 2\portal2.exe(RtlGetAppContainerNamedObjectPath+0x77147b8e) [0x77147b8e]
(this is the only log I've got, will update the issue if I confirm it always looks like this)
edit: got a log that is almost exactly the same, only difference is addresses
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by examining the reported Portal 2 fullscreen alt-tab crash and the stack frames around sar.dll's Engine::Frame_Hook and Portal 2's DestroyThreadPool. Compare the two logs and attempt to establish whether the SAR hook is involved. Done means identifying a reproducible cause or documenting the next concrete diagnostic step.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100