Running sar_update twice crashes the game
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 122
- Forks
- 45
- PR merge metrics
- No merged PRs in 30d
Description
- Be on latest release (1.12.7)
- Run
sar_update pretwice
Discovered by wanting to update from 1.12.7-pre5 (or some 1.12.7 prerelease) to some version with sar_dpi_scale. Ran sar_update first and then sar_update pre immediately after
Also replicated by running sar_update pre force twice while using the latest prerelease (1.12.8-pre2)
Seems like the crash happens after the second download is finished as I believe i can read "Deleting old version.." being printed to console a split second before it crashes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue with sar_update pre twice, and with sar_update pre force twice, on the releases described in the report. Trace the sar_update entry point through the update and cleanup steps, especially the point after "Deleting old version.." is printed. Done means repeated updates complete without crashing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100