oxidecomputer / oxidecomputer/v-api

Mapper consumption is not atomic

Open
#451 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
8
Forks
5
Avg merge
1d 20h
Merged PRs (30d)
59

Description

There is a very obvious TOCTOU error in the consume_mapping_activation function. This operation needs to be made atomic. Callers depend on the correctness of the output to determine if they should apply a mapper.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Rust consume_mapping_activation function and reading its callers to understand how its result is used. Trace the check-and-consume path and add or run tests that exercise concurrent consumption; done means the operation is atomic and callers receive a correct result.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.