oxidecomputer / oxidecomputer/typify
New, flattened lottie schema doesn't work: 'if/then/else schemas are not supported'
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 898
- Forks
- 114
- Avg merge
- 4h 18m
- Merged PRs (30d)
- 14
Description
Due to the problem in #907 reported, I requested a new flattened schema from the lottie team.
They actually made a new format to be compliant with type generators, that conversation happened here: https://github.com/lottie/lottie-spec/issues/157
However, unfortunately, it looks like there's another issue.
Can
--- stderr
thread 'main' (531858) panicked at /home/robo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/typify-impl-0.5.0/src/merge.rs:293:9:
not implemented: if/then/else schemas are not supported
Is this a case where the lottie team would need to make more changes or is this something that can be fixed on the typify side?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the panic with the flattened Lottie schema and inspect typify-impl-0.5.0/src/merge.rs at the reported line. Compare the schema and the unsupported if/then/else handling to determine whether the change belongs in typify or the schema; done means the schema can be processed without this panic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100