oxidecomputer / oxidecomputer/typify
Implement "not"
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 898
- Forks
- 114
- Avg merge
- 4h 18m
- Merged PRs (30d)
- 14
Description
This is a feature-request to implement handling of "not".
relevant part of the code:
https://github.com/oxidecomputer/typify/blob/1f9bc52283ad7b449db2db77efc5d8e922ec7f4d/typify-impl/src/convert.rs#L1732
My schema makes use of this.
Thanks already for your work!
I felt a sense of adventure when I was looking for this and saw: yeah. somebody already made this! :-)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in typify-impl/src/convert.rs around line 1732, then read the linked JSON Schema reference for the semantics of "not". Trace how the conversion currently handles the relevant schema and define completion as support for schemas using "not" in generated Rust types, with corresponding project tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100