oxidecomputer / oxidecomputer/typify
`github-workflow` schema from json.schemastore.org not working
Open
Nobody has claimed this yet.
if/then
- Dominant language
- Rust
- Stars
- 898
- Forks
- 114
- Avg merge
- 4h 18m
- Merged PRs (30d)
- 14
Description
The following schema does not work with typify: https://json.schemastore.org/github-workflow
Here's what I did:
- Encountered
unhandled array validation - This can be fixed for using this branch: https://github.com/Holzhaus/typify/tree/array-val (I'll open a PR soon-ish)
- Now it works, but the root struct is missing. I found this error: https://github.com/oxidecomputer/typify/issues/313
- I edited to schema and added a title, now I get:
thread 'main' panicked at /home/jan/.cargo/git/checkouts/typify-06751e3ea48efeaf/776225f/typify-impl/src/merge.rs:1068:5: assertion failed: object_schema.pattern_properties.is_empty()
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failure with the github-workflow schema from json.schemastore.org and review typify-impl/src/merge.rs around the reported assertion. Read the related typify issue 313 and compare behavior with the array-val branch. Done means the schema is processed without the reported panic and the expected root struct is generated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json, rust
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100