oxidecomputer / oxidecomputer/typify

Empty module generated when no `title`

Open
#313 5 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
898
Forks
114
Avg merge
4h 18m
Merged PRs (30d)
14

Description

Given the following input:

{
  "type": "array",
  "minItems": 1,
  "uniqueItems": true,
  "items": {
    "type": "string"
  }
}

cargo-typify 0.0.13 generates

#![allow(clippy::redundant_closure_call)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::match_single_binding)]
#![allow(clippy::clone_on_copy)]

use serde::{Deserialize, Serialize};

I suppose it doesn't know what to call anything if title is missing. Maybe this should error?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the JSON Schema shown and inspect the generator entry point that handles schemas without a title. Trace why the generated Rust file contains only imports, then use the existing test structure if available to capture the expected behavior: no empty module should be emitted, or the input should produce a clear error.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.