oxidecomputer / oxidecomputer/typify

Panic with a schema having 'ref' with nested definitions

Open
#299 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
898
Forks
114
Avg merge
4h 18m
Merged PRs (30d)
14

Description

Trying to generate with Jupyter Notebook schema https://github.com/jupyter/nbformat/blob/main/nbformat/v4/nbformat.v4.schema.json

Ref to the nested definition: https://github.com/jupyter/nbformat/blob/main/nbformat/v4/nbformat.v4.schema.json#L168
Nested definition: https://github.com/jupyter/nbformat/blob/main/nbformat/v4/nbformat.v4.schema.json#L409

thread 'main' panicked at '$ref #/definitions/misc/metadata_name is missing', 

/Users/h7kanna/.cargo/registry/src/index.crates.io-6f17d22bba15001f/typify-impl-0.0.13/src/convert.rs:1029:32```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing generation with the linked Jupyter Notebook schema, then inspect typify-impl/src/convert.rs around the reported panic at line 1029. Trace how the nested definition and its $ref are resolved; done means the schema generates Rust types without panicking and the nested reference is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.