oxidecomputer / oxidecomputer/transceiver-control

Ethernet compliance codes can be emitted as strings that we can't parse

Open
#475 0 comments 0 reactions 1 assignee View on GitHub

@bnaecker is already working on this.

Since Aug 28, 2026.

Dominant language
Rust
Stars
9
Forks
0
Avg merge
57m
Merged PRs (30d)
3

Description

We're using Display and FromStr to read / write the Ethernet compliance codes when they appear in an API. Here are the impls:

https://github.com/oxidecomputer/transceiver-control/blob/1f94d981731f20f553e957752c5027d15be0f49d/decode/src/datapath.rs#L151-L189

These two don't match. If we get an unknown code from the module, we write it out as Unknown (0xAA). But we have a wildcard match in the FromStr impl that will catch that and return an error. We need to parse it the same way we emit it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.