oxidecomputer / oxidecomputer/skepsis
Respect `linguist-generated` git attribute
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 129
- Forks
- 9
- Avg merge
- 52m
- Merged PRs (30d)
- 7
Description
I'm already finding this useful, so thanks! The monorepo at my work has a lot of autogenerated files, and most substantial changes end up regenerating them, which can lead to quite noisy diffs. Github's code review view will auto-hide files marked as linguist-generated or binary in the repo .gitattributes file, and I think it'd be useful to replicate that here?
Happy to put up a PR, but thought I'd open an issue first to see if you agree. I think the best approach is probably to shell out to git if in a git repo (or git-colocated jj repo) and run git attr, rather than parse the .gitattributes file in node, as I think the logic for git attributes can get pretty gnarly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the code-review diff handling and the repository integration entry point. The issue proposes using Git attributes from .gitattributes via git attr, including Git-colocated jj repositories, so inspect how those environments are detected. Done means files marked linguist-generated or binary are hidden in the review view.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100