oxidecomputer / oxidecomputer/rfd-api

Tell meilisearch not to treat `_` as a separator

Open
#120 0 comments 1 reaction 1 assignee View on GitHub

@augustuswm is already working on this.

Since Apr 4, 2024.

Dominant language
Rust
Stars
95
Forks
22
Avg merge
6d 19h
Merged PRs (30d)
17

Description

image

Thanks @hawkw for noticing. I think in general we would prefer underscores not to be treated like whitespace.

The ability to configure separators was added in Meilisearch 1.4.0. We are on version 0.24.3 of the Rust SDK, which looks like it wraps Meilisearch 1.2.0. That may not be correct, though, because in theory this underscore behavior started in 1.3.0 (source).

The behavior of the underscore has been changed since Meilisearch v1.3.0 and is now considered a separator by default

We would have to upgrade to 0.25.0 to get 1.7.0 to configure the separator.

https://github.com/meilisearch/meilisearch-rust/releases

https://github.com/oxidecomputer/rfd-api/blob/070edfd8bb354ca0e98d8420cd72fcdef7a4745f/Cargo.toml#L44

https://github.com/oxidecomputer/rfd-api/blob/070edfd8bb354ca0e98d8420cd72fcdef7a4745f/Cargo.toml#L111-L112

https://github.com/meilisearch/meilisearch-rust/releases/tag/v0.25.0

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.