oxidecomputer / oxidecomputer/quartz

Ignition target: Consider heavier filtering on fault inputs

Open
#348 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ignition-target
Dominant language
VHDL
Stars
22
Forks
2
Avg merge
9h 38m
Merged PRs (30d)
1

Description

Right now there's a three cycle filter on these, which is 60ns given our 50MHz clock: https://github.com/oxidecomputer/quartz/blob/main/hdl/ip/bsv/ignition/IgnitionTargetWrapper.bsv#L45-L57

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at hdl/ip/bsv/ignition/IgnitionTargetWrapper.bsv lines 45-57 and inspect the existing three-cycle filter and its fault inputs. Clarify with maintainers what heavier filtering should mean and how it should be validated. Done requires an agreed filtering behavior implemented and verified against the 50MHz timing context.

Written by the indexing model from the issue text.

Assessment

Domain
embedded-iot
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.