oxidecomputer / oxidecomputer/quartz
Consider better parameterizing i2c controller vc with using some common values already built
Nobody has claimed this yet.
- Dominant language
- VHDL
- Stars
- 22
- Forks
- 2
- Avg merge
- 9h 38m
- Merged PRs (30d)
- 1
Description
From: https://github.com/oxidecomputer/quartz/pull/256#discussion_r1915112781
We could maybe add a SIMULATION variant of mode_t to be able to use the same parameters (via get_i2c_settings()) across our various simulations. https://github.com/oxidecomputer/quartz/blob/main/hdl/ip/vhd/i2c/common/i2c_common_pkg.vhd#L61-L86
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with hdl/ip/vhd/i2c/common/i2c_common_pkg.vhd, especially lines 61-86, and review the linked pull request discussion. Trace get_i2c_settings() and the simulation parameters it currently uses; the work is done when a SIMULATION mode_t variant allows the same parameters across the various simulations.
Written by the indexing model from the issue text.
Assessment
- Domain
- embedded-iot
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100