oxidecomputer / oxidecomputer/propolis
Suggest setting nvme max data transfer size
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
@jmpesp was looking to figure out a maximum data transfer size and pointed out that things are set to 0 right now. I took a brief look at disks on romulus:
> ::prtconf -d nvme | ::devinfo -d | ::printf "%s 0x%x\n" nvme_t n_idctl->id_model n_idctl->id_mdts
Micron_7300_MTFDHBE3T2TDG 0x5
Micron_7300_MTFDHBE3T8TDF 0x5
WUS4C6432DSP3X3 0x0
HP SSD EX950 1TB 0x6
HP SSD EX950 1TB 0x6
SAMSUNG MZQL23T8HCLS-00A07 0x9
While yes everything is virtual, I suspect we probably do want to have something here, even when backed by a simple file or device.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named in the issue. Start by locating the NVMe controller and identify-data handling, then inspect how the maximum data transfer size is currently represented when backed by a file or device. Done means the virtual controller reports an appropriate nonzero maximum transfer size for both backing cases, with tests covering the resulting identify data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100