oxidecomputer / oxidecomputer/propolis
long lines confuse PHD's serial listener
Open
@iximeow is already working on this.
Since Oct 1, 2024.
testing
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
at least, it's extremely likely it's carriage returns that come with long lines, something to that effect.
#756 landed with this kind of hokey workround: when writing a very long line to a guest, PHD would appear to hang. it's certainly that PHD is waiting for the guest to echo back what it wrote, but the guest wrote \r\n and the expected character is just a bit beyond that.
whatever it is, this really ought to be fixed in PHD, rather than a one-off helper in boot_order.rs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.