oxidecomputer / oxidecomputer/propolis
Panic count metrics could possibly be combined for easier analysis
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
Propolis maintains two metrics counting panics in the guest, and distinguishes between guest- and host-handled panics as different timeseries. Here:
and here:
We may want to collapse these into one timeseries counting total panics, with a field to indicate who handled it (guest or host). But it's not clear from the PVPANIC documentation whether these two are mutually exclusive. If not, two timeseries would be needed. But if so, we may want to collapse them.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in bin/propolis-server/src/lib/stats/pvpanic.rs at the two referenced metrics, then read the linked QEMU PVPANIC documentation to determine whether guest- and host-handled panics are mutually exclusive. Done means documenting that behavior and choosing whether to retain the two timeseries or combine them with a handler field.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- observability-sre
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100