oxidecomputer / oxidecomputer/propolis

nvme firmware log page should maybe have more than zeros

Open
#603 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
270
Forks
42
Avg merge
4d 5h
Merged PRs (30d)
6

Description

While taking the illumos nvme tests for a spin on Propolis one thing it tripped over was the fact that the firmware log page was basically all zeros. This is obviously very low priority, but firmware slot 0 is not a valid firmware slot id. This is super low priority, but one should consider:

  • Indicating that the current firmware slot is slot 1.
  • Faking up some version string.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the NVMe firmware log page handling and compare its output with the illumos NVMe tests mentioned in the issue. Determine the expected current firmware slot and version representation; done means the page no longer reports an invalid slot 0 and exposes a suitable version string.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.