oxidecomputer / oxidecomputer/propolis
Update chipset to consistently identify as PIIX4
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
The lesser parts of the chipset (ACPI and ISA bridge) are inconsistent when it comes to their PCI identifiers. The ACPI device properly identifies as PIIX4 (0x7113), although the struct is improperly titled piix3-pm. The ISA bridge device cargo-culted the identifier used by c-bhyve (0x7000), which corresponds to a PIIX3 part. We should update that to PIIX4 (0x7110), which will require another subsystem ID allocation from OANA. At the same time, the piix3-pm references should be fixed to piix4.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the Rust source for the piix3-pm references and the ISA bridge PCI identifier. Confirm the ACPI and ISA bridge devices consistently use PIIX4 identifiers, including 0x7110, and check the required OANA subsystem ID allocation. Done means the identifiers and related names consistently identify PIIX4.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100