oxidecomputer / oxidecomputer/propolis
LPC UART device pause/resume could be better
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
The Entity trait provides no-op pause and resume default methods that can optionally be implemented by entities. These methods are used by the migration code to pause devices before migrating their state and resume them on the target.
It is possible for the LPC UART device to continue receiving data after devices are paused, as a user might be connected to the console and typing. To allow for a consistent snapshot of device state during migration, the LPC UART should implement pause and resume methods.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Entity trait's pause and resume defaults, then trace the migration code that pauses devices and resumes them on the target. Locate the LPC UART device implementation and determine how its receive path behaves during migration. Done means the UART stops receiving while paused and resumes afterward, with relevant tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100