oxidecomputer / oxidecomputer/propolis
Instance specs and machine init disagree about the necessity of COM1
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
It's technically possible to create an instance spec with no serial device associated with COM1, but if you try, propolis_server::initializer::MachineInitializer::initialize_uart will panic. It would be nice to resolve the tension between these modules.
However, we have no scenario where we actually want to omit this device for now, so this isn't needed anytime soon.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read the instance-spec definitions alongside propolis_server::initializer::MachineInitializer::initialize_uart to understand how COM1 is represented and initialized. Determine the intended behavior when COM1 is omitted, then make the two modules agree and verify that initialization no longer panics for the supported specification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100