oxidecomputer / oxidecomputer/propolis

Consider putting PCI bridge support behind a feature guard

Open
#227 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
270
Forks
42
Avg merge
4d 5h
Merged PRs (30d)
6

Description

Because we currently have no production scenarios that require PCI-PCI bridges, it might be valuable to gate them (in propolis-lib/propolis-server) behind a compile-time feature check to reduce unused, latent, potentially-attackable code in production Propolis binaries.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the PCI bridge support in propolis-lib and propolis-server, then trace how those crates are built into production Propolis binaries. Identify the compile-time feature boundary and confirm which existing checks cover PCI-PCI bridges. Done means production builds exclude the support by default while an enabled feature preserves the existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.