oxidecomputer / oxidecomputer/propolis
acpi: device order may change in DSDT if the spec changes
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
https://github.com/oxidecomputer/propolis/pull/1165 introduced DsdtDeviceType as a way to control the order in which devices are rendered in the DSDT table. This makes the generated DSDT code stable and independent from the VM spec.
But if there are multiple generators for a device type (such is the case for serial ports), the relative order of these devices may change depending on their SpecKey value.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading pull request 1165 and the DsdtDeviceType implementation to trace how multiple generators for one device type are ordered. Check the serial-port generator path and any related tests. Done means generated DSDT device order remains stable when the VM spec or SpecKey values change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100