oxidecomputer / oxidecomputer/propolis
`block_worker_collection_*` probes should include IDs
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
consider the block_worker_collection_wake and block_worker_collection_woken probes here:
https://github.com/oxidecomputer/propolis/blob/d59ac2dcf1a24f08f82ea803978d7a3351525c17/lib/propolis/src/block/attachment.rs#L1023-L1044
... how does one know which device is seeing workers get kicked, and which device has what number of remaining idled workers? we'd want a device id like block_strategy!() to tell, so we should get one in there..
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/propolis/src/block/attachment.rs at the referenced block_worker_collection_wake and block_worker_collection_woken probes around lines 1023–1044. Compare their probe arguments with block_strategy!() to understand the existing device identifier pattern. Done means both probes identify the device and report which device has the remaining idled-worker count.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100