oxidecomputer / oxidecomputer/propolis
refactor attestation code to be more async ergonomic
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
@hawkw had some good feedback on #1091 that we punted on for the sake of urgency. In particular, a couple of things about the attestation server are a bit awkward:
JoinHandleon the server is a leftover from a previous design and could be removed (https://github.com/oxidecomputer/propolis/pull/1091#discussion_r3030246733)- we could probably make the VM conf into a
tokio::sync::watchchannel (https://github.com/oxidecomputer/propolis/pull/1091#discussion_r3030275443)
Both of these would be nice improvements to the code and seem worth doing.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the attestation server implementation and reading the linked #1091 review discussions about JoinHandle and VM configuration. Trace how the server is started and how VM configuration is passed, then verify that the server no longer exposes the leftover JoinHandle and that configuration uses a tokio::sync::watch channel without breaking existing checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100