oxidecomputer / oxidecomputer/propolis
explore better path forward for clippy check failure
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 270
- Forks
- 42
- Avg merge
- 4d 5h
- Merged PRs (30d)
- 6
Description
In #1091 there was a clippy check that failed here: https://github.com/oxidecomputer/propolis/blob/2c9d7052cc12b3feca1c5a0e09d10b724b8e7cb4/xtask/src/task_clippy.rs#L46-L57
The less-expedient but more correct solution to fix this is to make propolis-client not re-export propolis-client. Unclear to me how much work that is, but filing for tracking.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with xtask/src/task_clippy.rs lines 46-57 and the clippy failure referenced from issue #1091. Trace how propolis-client is re-exported and determine the scope of removing that re-export. The work is done when the clippy check passes with the more correct dependency structure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100