oxidecomputer / oxidecomputer/propolis

[vsock] Be more explict with host side socket shutdown

Open
#1,102 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
270
Forks
42
Avg merge
4d 5h
Merged PRs (30d)
6

Description

Currently when we detect an EOF on a read from the underlying host socket that we are proxying to and from we treat this as if the TCP socket has closed. Under these conditions we are sending a vsock packet that tells the guest we have shut down our read and write halves via VIRTIO_VSOCK_SHUTDOWN_F_SEND | VIRTIO_VSOCK_SHUTDOWN_F_RECEIVE.

It would be nice to be able to distinguish a close of the read and write halves independently.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the vsock proxy's handling of EOF from the underlying host socket and the code that sends VIRTIO_VSOCK_SHUTDOWN_F_SEND and VIRTIO_VSOCK_SHUTDOWN_F_RECEIVE. Done means read-half and write-half shutdowns can be distinguished and communicated independently to the guest.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.